Error 213: Insert Error: Column name or values don't match table definition

Hello,
I have had the below procedure working and in use for some time now,
and suddently i started getting the below error:
"Eorror 213: Insert Error: Column name or number of supplied values
does not match table definition"
Thank you
CREATE PROCEDURE bat_LogData (
@.ComputerName varchar(50),
@.UserDomain varchar(50),
@.UserName varchar(50),
@.Date_Time datetime,
@.Message varchar(128),
@.SubMessage varchar(128),
@.ErrorText varchar(128),
@.ErrorCode nvarchar(15),
@.smsguid nvarchar(41),
@.locale int,
@.scriptver nvarchar(15),
@.wshver nvarchar(15)
)
AS
INSERT INTO LogonScript_data VALUES (
@.ComputerName,
@.UserName,
@.UserDomain,
GetDate(),
@.Date_Time,
@.Message,
@.SubMessage,
@.ErrorText,
@.ErrorCode,
@.smsguid,
@.locale,
@.scriptver,
@.wshver
)
SELECT @.@.IDENTITY AS 'MessageID'
GOrdixon5652@.hotmail.com wrote:

> Hello,
> I have had the below procedure working and in use for some time now,
> and suddently i started getting the below error:
> "Eorror 213: Insert Error: Column name or number of supplied values
> does not match table definition"
> Thank you
> CREATE PROCEDURE bat_LogData (
> @.ComputerName varchar(50),
> @.UserDomain varchar(50),
> @.UserName varchar(50),
> @.Date_Time datetime,
> @.Message varchar(128),
> @.SubMessage varchar(128),
> @.ErrorText varchar(128),
> @.ErrorCode nvarchar(15),
> @.smsguid nvarchar(41),
> @.locale int,
> @.scriptver nvarchar(15),
> @.wshver nvarchar(15)
> )
> AS
> INSERT INTO LogonScript_data VALUES (
> @.ComputerName,
> @.UserName,
> @.UserDomain,
> GetDate(),
> @.Date_Time,
> @.Message,
> @.SubMessage,
> @.ErrorText,
> @.ErrorCode,
> @.smsguid,
> @.locale,
> @.scriptver,
> @.wshver
> )
> SELECT @.@.IDENTITY AS 'MessageID'
> GO
I expect the table changed. Did you add or drop a column?
Always list the column names in an INSERT statement. Leaving them out
as you have done will inevitably make your code less reliable and
harder to debug. For example:
INSERT INTO LogonScript_data (
computername, username, userdomain, dt, date_time, message,
submessage,
errortext, errorcode, smsguid, locale, scriptver, wshver)
VALUES
(@.computername, @.username, @.userdomain, GETDATE(), @.date_time,
@.message,
@.submessage, @.errortext, @.errorcode, @.smsguid, @.locale, @.scriptver,
@.wshver
)
David Portas
SQL Server MVP
--